Refactor the DirectionalNavigationAdapter
#592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DirectionalNavigationAdapter to support a configurable pointer-based navigation system while updating related tap/key handling in the visual reader.
- Updated VisualReaderViewController to use the new pointer configuration and observer event types.
- Modified PointerEvent to conform to CaseIterable.
- Refactored DirectionalNavigationAdapter to introduce PointerPolicy and KeyboardPolicy while deprecating older parameters.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TestApp/Sources/Reader/Common/VisualReaderViewController.swift | Updated adapter instantiation and changed event observers from tap to activate. |
| Sources/Navigator/Input/Pointer/PointerEvent.swift | Added CaseIterable conformance to PointerType. |
| Sources/Navigator/DirectionalNavigationAdapter.swift | Refactored configuration options (PointerPolicy and KeyboardPolicy), updated binding logic, and deprecated older initializer. |
mickael-menu
force-pushed
the
fix/directional-adapter
branch
from
31b29bf to
338d16d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DirectionalNavigationAdapter by updating its configuration options and enhancing pointer and keyboard policies. Key changes include:
- Changing observer event types in VisualReaderViewController from .tap to .activate.
- Updating PointerType to conform to CaseIterable.
- Reorganizing the DirectionalNavigationAdapter with new PointerPolicy and KeyboardPolicy structures and deprecating the old TapEdges initializer.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TestApp/Sources/Reader/Common/VisualReaderViewController.swift | Updated pointer event observers to use .activate instead of .tap, aligning with the new pointer policy. |
| Sources/Navigator/Input/Pointer/PointerEvent.swift | Extended PointerType with CaseIterable for easier pointer type iteration. |
| Sources/Navigator/DirectionalNavigationAdapter.swift | Refactored configuration by introducing PointerPolicy and KeyboardPolicy, with adjustments to initializer logic and deprecation of old TapEdges. |
Comments suppressed due to low confidence (1)
TestApp/Sources/Reader/Common/VisualReaderViewController.swift:89
- The change from .tap to .activate should be thoroughly verified to ensure it aligns with the intended pointer event handling defined in the new PointerPolicy. Consider confirming that all affected event behaviors are consistent with the adapter’s updated configuration.
navigator.addObserver(.activate { [weak self] _ in
03ce40d to
bd618a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectionalNavigationAdapterconfiguration option.